Light theme support. #422
Merged
Light theme support. #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mario-nt
force-pushed
the
#421-light-theme
branch
from
aface50 to
f78bc3f
Compare
mario-nt
force-pushed
the
#421-light-theme
branch
from
9dd1a81 to
e1e0439
Compare
- placeholder buttons for light/dark/system themes - renamed themes - dark/light mode now works on firefox - New color mode selector component
mario-nt
force-pushed
the
#421-light-theme
branch
from
4a1393a to
4ee9702
Compare
|
@josecelano Ready for review |
josecelano
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
And God said, “Let there be light,” and there was light.
Awesome @mario-nt! good job!
I also like the changes in fonts, It makes all more clean and beatiful.
|
ACK 4ee9702 |
Thanks!, I really wanted to implement this one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #421.